repo: Make the ordering consistent between abort/complete_transaction
authorJasper St. Pierre <jstpierre@mecheye.net>
Thu, 5 Sep 2013 19:30:15 +0000 (15:30 -0400)
committerJasper St. Pierre <jstpierre@mecheye.net>
Sat, 7 Sep 2013 00:28:42 +0000 (20:28 -0400)
This just makes the functions nicer to stare at.

https://bugzilla.gnome.org/show_bug.cgi?id=707644

src/libostree/ostree-repo.c

index aaee9a1fe74fce8c552b579f4be93bc3a3646382..1b60474a439739bd69e7dbf10d92e8e6e20beadc 100644 (file)
@@ -1264,14 +1264,14 @@ ostree_repo_commit_transaction_with_stats (OstreeRepo     *self,
   if (!cleanup_tmpdir (self, cancellable, error))
     goto out;
 
-  if (!ot_gfile_ensure_unlinked (self->transaction_lock_path, cancellable, error))
-    goto out;
-
   if (self->loose_object_devino_hash)
     g_hash_table_remove_all (self->loose_object_devino_hash);
 
   self->in_transaction = FALSE;
 
+  if (!ot_gfile_ensure_unlinked (self->transaction_lock_path, cancellable, error))
+    goto out;
+
   if (out_metadata_objects_total) *out_metadata_objects_total = self->txn_metadata_objects_total;
   if (out_metadata_objects_written) *out_metadata_objects_written = self->txn_metadata_objects_written;
   if (out_content_objects_total) *out_content_objects_total = self->txn_content_objects_total;
@@ -1302,10 +1302,11 @@ ostree_repo_abort_transaction (OstreeRepo     *self,
   if (!cleanup_tmpdir (self, cancellable, error))
     goto out;
 
-  self->in_transaction = FALSE;
   if (self->loose_object_devino_hash)
     g_hash_table_remove_all (self->loose_object_devino_hash);
 
+  self->in_transaction = FALSE;
+
   ret = TRUE;
  out:
   return ret;